Code review etiquette guide

Before you open the PR

• Self-review your diff line-by-line first.
• Run the test suite and linter locally.
• Write a PR description that explains why, not just what.
• Keep changes under 400 lines when possible.

Giving a review

• Start with what you like or what works well.
• Distinguish nitpicks from blocking issues with labels.
• Ask questions instead of issuing commands.
• Review within 4 business hours whenever possible.

Receiving a review

• Assume good intent — the reviewer wants the code to succeed.
• Respond to every comment, even if just “Done.”
• Push fixup commits and re-request review when ready.
• Don't take feedback personally; separate self from code.

The 3-pass method

1. Architecture pass: does the shape of the change make sense?
2. Correctness pass: edge cases, error handling, tests.
3. Style pass: naming, formatting, consistency.